Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds initial LINSTOR storage backend support to Sunbeam’s storage backends, along with unit-test coverage and integration into the shared backend test matrix.
Changes:
- Introduces
LinstorBackendandLinstorConfigundersunbeam.storage.backends.linstor. - Adds new unit tests for the LINSTOR backend and config validation.
- Expands shared backend fixtures/tests to include LINSTOR in uniqueness and expectation checks.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
sunbeam-python/sunbeam/storage/backends/linstor/backend.py |
New LINSTOR backend + Pydantic config model. |
sunbeam-python/sunbeam/storage/backends/linstor/__init__.py |
Declares the new backend package. |
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py |
Adds linstor_backend fixture and includes it in any_backend. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py |
Extends shared backend uniqueness/expectation tests to include LINSTOR. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_linstor.py |
New LINSTOR-specific backend/config validation tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmad-can
force-pushed
the
feature/generate-linstor-charm
branch
from
5ad2fc2 to
9adbd58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/983855